Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the token synchronize weight for existing tokens #2660

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

indeewari
Copy link
Contributor

@indeewari indeewari commented Jan 6, 2025

Proposed changes in this pull request

The synchronize block at the token issuance path seems to lock read only flow, where issuing existing token. For readonly flow, there is no requirement of a synchronize lock. This refactoring reduces the traffic at the synchronized block.

When should this PR be merged

After approval of the Authorization product team and the product owner.

Follow up actions

PR builder test success and QA approval.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 55.75%. Comparing base (8a01652) to head (5606e85).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...dlers/grant/AbstractAuthorizationGrantHandler.java 29.16% 13 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2660      +/-   ##
============================================
- Coverage     56.39%   55.75%   -0.64%     
- Complexity     8267     8415     +148     
============================================
  Files           632      632              
  Lines         46681    48509    +1828     
  Branches       8508     8968     +460     
============================================
+ Hits          26324    27047     +723     
- Misses        16592    17615    +1023     
- Partials       3765     3847      +82     
Flag Coverage Δ
unit 38.94% <29.16%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indeewari indeewari marked this pull request as ready for review January 8, 2025 08:29
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12685956036

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12685956036
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12686897131

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12686897131
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants