Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from code review3 #3

Open
wants to merge 65 commits into
base: master
Choose a base branch
from

Conversation

kasunsiyambalapitiya
Copy link
Contributor

@kasunsiyambalapitiya kasunsiyambalapitiya commented Jan 7, 2019

Moving changes from changesFromCodeReview3 to master branch

kasunsiyambalapitiya and others added 30 commits March 10, 2017 09:33
Add log messages for all classes
added streams for saveReviewersToList method

added streams for savePrNumberAndRepoName method

replaced for loop with for each loop in readTheReviewOutJSON method
add constants for Reviewers.java
Handle the response code recieved from Graphql API

Correct the message thrown in Exception
close resources with try with resources

Seperate tokens to a property file

Fix bug from history simplificatio

If two commits in the history of a file cancel each other out (the changes are reversed), then Git detect this and simplifies the git log output of the file by leaving out those two commits.
Fix to get reviewers full name

fix property files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant