Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: MTLS Support in API level #1349

Closed
wants to merge 12 commits into from
Closed

Add: MTLS Support in API level #1349

wants to merge 12 commits into from

Conversation

BLasan
Copy link
Contributor

@BLasan BLasan commented Jul 5, 2023

Purpose

$subject

CR structure

apiVersion: dp.wso2.com/v1alpha1
kind: Authentication
metadata:
  name: sand-http-bin-authentication
spec:
  override:
    type: ext
    ext:
      mutualSSL: mandatory
      disabled: false
      serviceRef:
        group: wso2/v1alpha2
        kind: Backend
        name: ext_authz-server
        port: 1234
      authTypes:
        apiKey:
          - in: Header
            name: x-api-key
  default:
    mutualSSL: mandatory
    type: ext
    ext:
      serviceRef: 
        group: wso2/v1alpha2
        kind: Backend
        name: ext_authz-server
        port: 1234
      authTypes:
        apiKey:
          - in: Header
            name: x-api-key
  targetRef:
    kind: API
    name: http-bin-api1 #provide API ref name
    group: ""

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (8ee77b0) 25.00% compared to head (770e9ad) 24.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   25.00%   24.93%   -0.08%     
==========================================
  Files         129      130       +1     
  Lines       15010    15057      +47     
  Branches     2414     2414              
==========================================
  Hits         3754     3754              
- Misses      11123    11170      +47     
  Partials      133      133              
Flag Coverage Δ
adapter 23.67% <ø> (?)
config-deployer-service 20.86% <ø> (?)
idp-domain-service 80.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 259 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BLasan BLasan force-pushed the mtls-auth branch 2 times, most recently from 594f12f to 4fa9783 Compare July 6, 2023 08:26
@BLasan BLasan marked this pull request as ready for review July 6, 2023 09:04
@BLasan BLasan force-pushed the mtls-auth branch 2 times, most recently from f3c857d to 86dc66c Compare July 11, 2023 04:01
@BLasan BLasan force-pushed the mtls-auth branch 5 times, most recently from 7b2c4a2 to afce7ce Compare July 17, 2023 10:19
@AmaliMatharaarachchi AmaliMatharaarachchi marked this pull request as draft July 25, 2023 04:35
@Krishanx92
Copy link
Contributor

This will added with following PR: #1857

@Krishanx92 Krishanx92 closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants