Add required field to OAuth2 #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgayangi
added
trigger-action
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
===========================================
- Coverage 80.10% 26.52% -53.59%
===========================================
Files 9 124 +115
Lines 548 14528 +13980
Branches 246 2575 +2329
===========================================
+ Hits 439 3854 +3415
- Misses 109 10550 +10441
- Partials 0 124 +124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sgayangi
added
Do Not Merge
and removed
trigger-action
sgayangi
force-pushed
the
#1839-mtls-part-2
branch
from
f57e000 to
d3f834b
Compare
sgayangi
added
trigger-action
Krishanx92
added
trigger-action
github-actions
bot
removed
the
trigger-action
sgayangi
added
trigger-action
sgayangi
force-pushed
the
#1839-mtls-part-2
branch
from
426ec18 to
74a2343
Compare
github-actions
bot
removed
the
trigger-action
sgayangi
added
trigger-action
Tharsanan1
approved these changes
Jan 17, 2024
github-actions
bot
removed
the
trigger-action
| import org.wso2.apk.enforcer.commons.model.InternalKeyConfig; | ||
| import org.wso2.apk.enforcer.commons.model.JWTAuthenticationConfig; | ||
| import org.wso2.apk.enforcer.commons.model.RequestContext; | ||
| import org.wso2.apk.enforcer.commons.model.*; |
There was a problem hiding this comment.
if possible let's remove star imports
| @@ -1,5 +1,7 @@ | |||
| Feature: Test mTLS between client and gateway with client certificate sent in header | |||
| Scenario: Test mandatory mTLS and enabled OAuth2 with a valid client certificate in header | |||
|
|
|||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose