Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common place for cp related config in helm template #2270

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

Krishanx92
Copy link
Contributor

Fix #2259

@Krishanx92 Krishanx92 added the trigger-action When this includes apk actions getting trigger for pr label Apr 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.76%. Comparing base (f2f81ed) to head (08ee89e).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2270   +/-   ##
=======================================
  Coverage   27.76%   27.76%           
=======================================
  Files         124      124           
  Lines       14895    14895           
  Branches     2681     2681           
=======================================
  Hits         4135     4135           
  Misses      10623    10623           
  Partials      137      137           
Flag Coverage Δ
adapter 27.34% <ø> (ø)
common-controller 4.07% <ø> (ø)
config-deployer-service 25.99% <ø> (ø)
idp-domain-service 80.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krishanx92 Krishanx92 merged commit d23b4cf into wso2:main Apr 4, 2024
11 of 12 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to have a common place to enable CP configurations in helm values yaml
3 participants