-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SCIM attributes from core schema to user schema #6140
base: master
Are you sure you want to change the base?
Conversation
PR builder started |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6140 +/- ##
============================================
- Coverage 41.40% 41.26% -0.15%
+ Complexity 15051 14816 -235
============================================
Files 1775 1775
Lines 121747 119169 -2578
Branches 20284 19927 -357
============================================
- Hits 50414 49178 -1236
+ Misses 63849 62612 -1237
+ Partials 7484 7379 -105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12237243974
Proposed changes in this pull request
urn:ietf:params:scim:schemas:core:2.0:User:phoneNumbers.fax
andurn:ietf:params:scim:schemas:core:2.0:User:phoneNumbers.fax
are incorrectly placed under theurn:ietf:params:scim:schemas:core:2.0
dialect.This PR moves them to the
urn:ietf:params:scim:schemas:core:2.0:User
schema.Related Issues
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation