Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracle an mssql specific queries for queryWithOutCreatedTime #6207

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mpmadhavig
Copy link
Contributor

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12351360281

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.41%. Comparing base (b4c7215) to head (414bfdd).
Report is 223 commits behind head on master.

Files with missing lines Patch % Lines
...ration/mgt/core/dao/impl/ConfigurationDAOImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6207      +/-   ##
============================================
+ Coverage     40.93%   45.41%   +4.48%     
+ Complexity    15735    13987    -1748     
============================================
  Files          1812     1616     -196     
  Lines        126414   100302   -26112     
  Branches      22448    16933    -5515     
============================================
- Hits          51746    45553    -6193     
+ Misses        67057    48066   -18991     
+ Partials       7611     6683     -928     
Flag Coverage Δ
unit 27.94% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12351360281
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12351360281

@mpmadhavig
Copy link
Contributor Author

Since unit testing for different types of dbs are not possible skipping the unit tests.

@mpmadhavig mpmadhavig merged commit 4821563 into wso2:master Jan 2, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants