Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove roles and groups view scope check from login and registrations #6218

Merged

Conversation

PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented Dec 18, 2024

Proposed changes in this pull request

This PR removes the role and group view scope check from the login and registration sections.

The initial plan was to modify the token issuance logic to include these missing scopes in the console user token. However, this approach was revised. Instead of requiring these scopes, we decided to hide rule-based password expiry functionality for users without these permissions.

As a result, this PR removes the check on role and group scopes in the login and registration section.

Related Issues

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.74%. Comparing base (e24e872) to head (e82de1e).
Report is 164 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6218      +/-   ##
============================================
+ Coverage     45.63%   45.74%   +0.10%     
- Complexity    14087    14265     +178     
============================================
  Files          1631     1633       +2     
  Lines        101493   103279    +1786     
  Branches      17763    18293     +530     
============================================
+ Hits          46316    47240     +924     
- Misses        48474    49231     +757     
- Partials       6703     6808     +105     
Flag Coverage Δ
unit 28.40% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 2, 2025

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12592856364

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12592856364
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12592856364

@PasinduYeshan PasinduYeshan merged commit e78b593 into wso2:master Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants