Merge pull request #762 from Thisara-Welmilla/fix-issue-not-logging-e…

…rrors Fix not logging errors from API server.
wso2 · Dec 18, 2024 · d9ce3b6 · d9ce3b6
2 parents aabb4d8 + 4e96ccc
commit d9ce3b6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/...rbon/identity/api/server/authenticators/v1/core/ServerAuthenticatorManagementService.java b/...rbon/identity/api/server/authenticators/v1/core/ServerAuthenticatorManagementService.java
@@ -1010,13 +1010,15 @@ private APIError handleIdPException(IdentityProviderManagementException e,
      */
     private APIError handleAuthenticatorException(AuthenticatorMgtException e) {
 
-        ErrorResponse errorResponse = new ErrorResponse.Builder()
+        ErrorResponse.Builder errorResponseBuilder = new ErrorResponse.Builder()
                 .withCode(e.getErrorCode())
                 .withMessage(e.getMessage())
-                .withDescription(e.getDescription()).build();
+                .withDescription(e.getDescription());
         Response.Status status;
+        ErrorResponse errorResponse;
 
         if (e instanceof AuthenticatorMgtClientException) {
+            errorResponse = errorResponseBuilder.build(log, e.getMessage());
             if (e.getErrorCode() != null) {
                 String errorCode = e.getErrorCode();
                 errorCode =
@@ -1027,6 +1029,7 @@ private APIError handleAuthenticatorException(AuthenticatorMgtException e) {
             errorResponse.setDescription(e.getDescription());
             status = Response.Status.BAD_REQUEST;
         } else if (e instanceof AuthenticatorMgtServerException) {
+            errorResponse = errorResponseBuilder.build(log, e, e.getMessage());
             if (e.getErrorCode() != null) {
                 String errorCode = e.getErrorCode();
                 errorCode =
@@ -1037,6 +1040,7 @@ private APIError handleAuthenticatorException(AuthenticatorMgtException e) {
             errorResponse.setDescription(e.getDescription());
             status = Response.Status.INTERNAL_SERVER_ERROR;
         } else {
+            errorResponse = errorResponseBuilder.build(log, e, e.getMessage());
             status = Response.Status.INTERNAL_SERVER_ERROR;
         }
         return new APIError(status, errorResponse);