Set Api Based Authentication Flag #550
Conversation
|
Hasanthi Dissanayake seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| @@ -511,6 +512,9 @@ private Authenticator addLocalAuthenticator(LocalAuthenticatorConfig config) { | |||
| authenticator.setName(config.getName()); | |||
| authenticator.setDisplayName(config.getDisplayName()); | |||
| authenticator.setIsEnabled(config.isEnabled()); | |||
| if (config.getProperties().length > 0 && IS_API_BASED_SUPPORTED.equals(config.getProperties()[0].getName())) { | |||
There was a problem hiding this comment.
shall we add a null check here is there is any possibility of config.getProperties() being null
| @@ -36,7 +37,7 @@ public class InboundAuthSAML2Config { | |||
|
|
|||
| private List<String> destinationURLs = null; | |||
|
|
|||
| private Integer metadataValidityPeriod; | |||
| private BigDecimal metadataValidityPeriod; | |||
There was a problem hiding this comment.
Let remove this file from the commit. Seems like a previous editor of the api definition hasn't updated the gen code.
There was a problem hiding this comment.
@ThaminduDilshan has added this code. He will test the fix after merging the PR.
| @@ -605,6 +607,11 @@ private List<AuthenticatorListItem> buildAuthenticatorListResponse( | |||
| authenticatorListItem.setName(config.getName()); | |||
| authenticatorListItem.setDisplayName(config.getDisplayName()); | |||
| authenticatorListItem.setIsEnabled(config.isEnabled()); | |||
| if (config.getProperties().length > 0 && IS_API_BASED_SUPPORTED.equals | |||
There was a problem hiding this comment.
Lets do null check here if there is any possibility of config.getProperties() getting null
| @@ -1040,6 +1040,10 @@ components: | |||
| type: boolean | |||
| default: true | |||
| example: true | |||
| isAPIBasedAuthentication: | |||
There was a problem hiding this comment.
Shall we change this to isAPIBasedAuthenticationSupported
DMHP
force-pushed
the
api
branch
2 times, most recently
from
c9ce271 to
c766e7f
Compare
Set Api Based Authentication Flag