Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for - Internal Server Error When Using Offset >= Total Organizations and Limit = 0 in Organization Discovery GET API #680

Closed
wants to merge 5 commits into from
Closed

Fix for - Internal Server Error When Using Offset >= Total Organizations and Limit = 0 in Organization Discovery GET API #680

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
359b263
Merge branch 'wso2:master' into master
kumardeepak5 Oct 10, 2024
649dc56
Merge branch 'wso2:master' into master
kumardeepak5 Oct 14, 2024
43a6fcd
respond empty links [Organization Discovery API] while limit is 0
kumardeepak5 Oct 14, 2024
80991ba
Merge branch 'master' of https://github.com/kumardeepak5/identity-api…
kumardeepak5 Oct 14, 2024
60c5ef5
Merge branch 'wso2:master' into master
kumardeepak5 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...tity.api.server.common/src/main/java/org/wso2/carbon/identity/api/server/common/Util.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ public static Map<String, String> buildPaginationLinks(int limit, int currentOff

Map<String, String> links = new HashMap<>();

if (limit == 0) {
return links;
}
StringBuilder otherParams = new StringBuilder();
if (!StringUtils.isEmpty(requiredAttributes)) {
otherParams.append("&attributes=").append(requiredAttributes);
Expand Down Expand Up @@ -181,6 +184,9 @@ public static Map<String, String> buildPaginationLinks(int limit, int currentOff

private static int calculateOffsetForPreviousLink(int offset, int limit, int total) {

if (offset >= total && limit == 0) {
return offset;
}
int newOffset = (offset - limit);
if (newOffset < total) {
return newOffset;
Expand Down
Loading