Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for saving idvp logo url per idvp instance. #727

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Remove support for saving idvp logo url per idvp instance. #727

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4073fd0
Remove support for saving idvp logo url per idvp instance.
AfraHussaindeen Oct 28, 2024
e9b7e9e
Restore image in request body and make it optional
AfraHussaindeen Nov 23, 2024
89b8021
Bump identity verification version
AfraHussaindeen Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions ...en/java/org/wso2/carbon/identity/api/server/idv/provider/v1/model/IdVProviderRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public class IdVProviderRequest {
private String type;
private String name;
private String description;
private String image;
private Boolean isEnabled;
private List<VerificationClaim> claims = null;

Expand Down Expand Up @@ -104,24 +103,6 @@ public void setDescription(String description) {
this.description = description;
}

/**
**/
public IdVProviderRequest image(String image) {

this.image = image;
return this;
}

@ApiModelProperty(example = "onfido-logo-url", value = "")
@JsonProperty("image")
@Valid
public String getImage() {
return image;
}
public void setImage(String image) {
this.image = image;
}

/**
**/
public IdVProviderRequest isEnabled(Boolean isEnabled) {
Expand Down Expand Up @@ -209,15 +190,14 @@ public boolean equals(java.lang.Object o) {
return Objects.equals(this.type, idVProviderRequest.type) &&
Objects.equals(this.name, idVProviderRequest.name) &&
Objects.equals(this.description, idVProviderRequest.description) &&
Objects.equals(this.image, idVProviderRequest.image) &&
Objects.equals(this.isEnabled, idVProviderRequest.isEnabled) &&
Objects.equals(this.claims, idVProviderRequest.claims) &&
Objects.equals(this.configProperties, idVProviderRequest.configProperties);
}

@Override
public int hashCode() {
return Objects.hash(type, name, description, image, isEnabled, claims, configProperties);
return Objects.hash(type, name, description, isEnabled, claims, configProperties);
}

@Override
Expand All @@ -229,7 +209,6 @@ public String toString() {
sb.append(" type: ").append(toIndentedString(type)).append("\n");
sb.append(" name: ").append(toIndentedString(name)).append("\n");
sb.append(" description: ").append(toIndentedString(description)).append("\n");
sb.append(" image: ").append(toIndentedString(image)).append("\n");
sb.append(" isEnabled: ").append(toIndentedString(isEnabled)).append("\n");
sb.append(" claims: ").append(toIndentedString(claims)).append("\n");
sb.append(" configProperties: ").append(toIndentedString(configProperties)).append("\n");
Expand Down
2 changes: 0 additions & 2 deletions ...ain/java/org/wso2/carbon/identity/api/server/idv/provider/v1/core/IdVProviderService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ private IdVProvider createIdVProvider(IdVProviderRequest idVProviderRequest) {
idVProvider.setIdVProviderName(idVProviderRequest.getName());
idVProvider.setIdVProviderDescription(idVProviderRequest.getDescription());
idVProvider.setEnabled(idVProviderRequest.getIsEnabled());
idVProvider.setImageUrl(idVProviderRequest.getImage());
if (idVProviderRequest.getClaims() != null) {
idVProvider.setClaimMappings(getClaimMap(idVProviderRequest.getClaims()));
}
Expand All @@ -277,7 +276,6 @@ private IdVProvider createUpdatedIdVProvider(IdVProvider oldIdVProvider,
idVProvider.setIdVProviderName(idVProviderRequest.getName());
idVProvider.setIdVProviderDescription(idVProviderRequest.getDescription());
idVProvider.setEnabled(idVProviderRequest.getIsEnabled());
idVProvider.setImageUrl(idVProviderRequest.getImage());
if (idVProviderRequest.getClaims() != null) {
idVProvider.setClaimMappings(getClaimMap(idVProviderRequest.getClaims()));
}
Expand Down
3 changes: 0 additions & 3 deletions .../org.wso2.carbon.identity.api.server.idv.provider.v1/src/main/resources/idv-provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,6 @@ components:
description:
type: string
example: identity verification provider
image:
type: string
example: "onfido-logo-url"
isEnabled:
type: boolean
example: true
Expand Down
Loading