-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 [WIP][NEW SIGNUP] Improve functionality #7229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-signup #7229 +/- ##
===========================================
Coverage 32.02% 32.02%
===========================================
Files 41 41
Lines 893 893
Branches 215 220 +5
===========================================
Hits 286 286
- Misses 557 587 +30
+ Partials 50 20 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
NipuniBhagya
approved these changes
Dec 20, 2024
brionmario
force-pushed
the
feat-sign-up-composer
branch
from
January 2, 2025 09:37
6d5b9c6
to
3956034
Compare
pavinduLakshan
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes several changes to the
features/admin.flow-builder-core.v1
module, focusing on code refactoring, adding new components, and updating existing ones. The most important changes include adding new hooks and components, modifying existing components for better functionality, and updating styles for a consistent user interface.New Hooks and Components:
useGetFlowBuilderCoreActions
hook to fetch actions supported by the flow builder (features/admin.flow-builder-core.v1/api/use-get-flow-builder-core-actions.ts
).OTPInputAdapter
component for handling OTP inputs (features/admin.flow-builder-core.v1/components/elements/components/adapters/input/otp-input-adapter.tsx
).Component Modifications:
DecoratedVisualFlow
component to extendVisualFlowPropsInterface
and removed redundantHTMLAttributes
(features/admin.flow-builder-core.v1/components/decorated-visual-flow.tsx
).CommonComponentPropertyFactory
andCommonWidgetPropertyFactory
to removepreviousValue
parameter from theonChange
method (features/admin.flow-builder-core.v1/components/element-property-panel/common-component-property-factory.tsx
,features/admin.flow-builder-core.v1/components/element-property-panel/common-widget-property-factory.tsx
). [1] [2]ElementProperties
component to usemerge
andset
for updating properties and variants (features/admin.flow-builder-core.v1/components/element-property-panel/element-properties.tsx
). [1] [2] [3] [4]Style Updates:
ButtonAdapter
component to ensure consistent appearance (features/admin.flow-builder-core.v1/components/elements/components/adapters/button-adapter.scss
).ButtonAdapter
component to includefullWidth
property and handle social button styling (features/admin.flow-builder-core.v1/components/elements/components/adapters/button-adapter.tsx
). [1] [2]Minor Enhancements:
InputLabelProps
toDefaultInputAdapter
andPhoneNumberInputAdapter
to handle required labels (features/admin.flow-builder-core.v1/components/elements/components/adapters/input/default-input-adapter.tsx
,features/admin.flow-builder-core.v1/components/elements/components/adapters/input/phone-number-input-adapter.tsx
). [1] [2]Related Issues
Related PRs
Checklist
Security checks