Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix My Account URL in Passkey flow #7449

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

SamudraUduwaka
Copy link
Contributor

@SamudraUduwaka SamudraUduwaka commented Jan 29, 2025

Purpose

Previously the Provided My Account link was invalid in "Sign in with passkey interrupted" page, as the link for the my account was generated by using the ServiceURLBuilder.create().setTenant(tenantDomain).build().getAbsolutePublicURL() method in fido2-auth.jsp page.

This PR will fix the My Account page validation by replacing above URL building process by IdentityManagementEndpointUtil.getUserPortalUrl(application.getInitParameter(IdentityManagementEndpointConstants.ConfigConstants.USER_PORTAL_URL), tenantDomain).

Tested Flow

Screen.Recording.2025-01-29.at.16.40.20.mov

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (1080563) to head (ea49e92).
Report is 40 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7449   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          42       42           
  Lines         936      936           
  Branches      227      227           
=======================================
  Hits          393      393           
  Misses        499      499           
  Partials       44       44           
Flag Coverage Δ
@wso2is/core 41.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@NipuniBhagya NipuniBhagya merged commit 9af5122 into wso2:master Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants