Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception handling when error occured during the rollback of organization creation failure #152

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Sep 20, 2024

Purpose

There is a rollback mechanism when org creation failure. But if the org deletion cause an exception the original issue which cause for the failure of the org creation flow will be not logged. Ideally, the published logs contains not the reason for org creation failure, but the reason for the failure of the rollback.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.89%. Comparing base (708ec31) to head (d137ed6).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...on/management/service/OrganizationManagerImpl.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #152      +/-   ##
============================================
+ Coverage     45.72%   45.89%   +0.17%     
- Complexity      440      442       +2     
============================================
  Files            47       47              
  Lines          2979     2983       +4     
  Branches        358      358              
============================================
+ Hits           1362     1369       +7     
+ Misses         1461     1458       -3     
  Partials        156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10958016741

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10958016741
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10958016741

@sadilchamishka sadilchamishka merged commit 151b138 into wso2:main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants