Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle depth -1 in isOrganization check #154

Closed
wants to merge 1 commit into from
Closed

Conversation

Yoshani
Copy link

@Yoshani Yoshani commented Oct 4, 2024

Purpose

When a suborg is deleted since stale data remains in SP_SHARED_APP table, when a shared parent app is updated those updates are tried to be done in non-existing deleted suborgs as well. For those nonexistent suborgs the hierarchy depth is returned as -1, and we can use this to return false in the isOrganization() check, which will in turn stop the other tasks related to shared app update from happening.

Related issues

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.86%. Comparing base (d137ed6) to head (fac884f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ement/service/util/OrganizationManagementUtil.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #154      +/-   ##
============================================
- Coverage     45.89%   45.86%   -0.04%     
  Complexity      442      442              
============================================
  Files            47       47              
  Lines          2983     2985       +2     
  Branches        358      359       +1     
============================================
  Hits           1369     1369              
- Misses         1458     1460       +2     
  Partials        156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yoshani
Copy link
Author

Yoshani commented Oct 4, 2024

Closing since return organizationDepth >= Utils.getSubOrgStartLevel(); line already handles this

@Yoshani Yoshani closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant