Block organization name with HTML content #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=========================================
Coverage 45.91% 45.91%
- Complexity 442 443 +1
=========================================
Files 47 47
Lines 2984 2988 +4
Branches 358 359 +1
=========================================
+ Hits 1370 1372 +2
- Misses 1458 1460 +2
Partials 156 156 ☔ View full report in Codecov by Sentry. |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11870513482
AnuradhaSK
reviewed
Nov 17, 2024
...arbon/identity/organization/management/service/constant/OrganizationManagementConstants.java
Outdated
Show resolved
Hide resolved
sadilchamishka
force-pushed
the
validate-org-name-for-html-content
branch
from
c4245e2 to
30a80d4
Compare
...rvice/src/main/java/org/wso2/carbon/identity/organization/management/service/util/Utils.java
Show resolved
Hide resolved
AnuradhaSK
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The organization name can have any character as there is no specific regular expression defined to validate organization name. Due to that malicious organization names with HTML content can be created and those organization names will be shown in the email send for the user invitations etc..
Email templates can be updated with HTML content by the administrators also. But as we have the capability to validate the organization name with HTML content while creating and update organizations, its better to have a validation until proper organization name regular expression is defined.