Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional file scanning issue that increases the server startup time #13636

Conversation

thisaltennakoon
Copy link
Contributor

Fix wso2/api-manager#3452

Current Behavior: The server startup time has increased due to unnecessary file scanning performed by Tomcat. This is caused by invalid characters in the CARBON_CLASSPATH.

  • For example, in Linux, a ':' appears at the beginning of the classpath.
  • In Windows, multiple occurrences of ';;' are present within the classpath.

Fix: This PR resolves the issue by properly processing the CARBON_CLASSPATH to remove invalid characters, optimizing the server startup time.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.96%. Comparing base (b7456cf) to head (a2aa1d8).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13636      +/-   ##
============================================
+ Coverage     18.44%   18.96%   +0.51%     
- Complexity      944      976      +32     
============================================
  Files           261      261              
  Lines         12045    12082      +37     
  Branches       1262     1265       +3     
============================================
+ Hits           2222     2291      +69     
+ Misses         9806     9772      -34     
- Partials         17       19       +2     
Flag Coverage Δ
integration_tests 18.96% <ø> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisaltennakoon thisaltennakoon merged commit 6385376 into wso2:master Jan 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional file scan at tomcat level in APIM-3.2.1 server startup.
2 participants