Skip to content

Commit

Permalink
Merge pull request #18868 from Thisara-Welmilla/improve-oidc_conformance
Browse files Browse the repository at this point in the history
Improve sending oidc-conformance-test chat notification.
  • Loading branch information
chamathns authored Jan 10, 2024
2 parents 7c8a7b0 + 1f5b1e7 commit 1ef6908
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/oidc-conformance-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ jobs:
echo "Sending Google Chat Message"
echo "==========================="
CONFORMANCE_SUITE_URL=https://localhost:8443
python3 ./product-is/oidc-conformance-tests/send_chat.py "$CONFORMANCE_SUITE_URL" "$GITHUB_RUN_NUMBER" "${{job.status}}" "${{github.repository}}" "${{github.run_id}}" "${{secrets.GOOGLE_CHAT_WEBHOOK_OIDC_TEST}}" "$RESOURCE" "OIDC Conformance Test"
python3 ./product-is/oidc-conformance-tests/send_chat.py "$CONFORMANCE_SUITE_URL" "$GITHUB_RUN_NUMBER" "${{job.status}}" "${{github.repository}}" "${{github.run_id}}" "${{secrets.GOOGLE_CHAT_WEBHOOK_OIDC_TEST}}&threadKey=oidc_conformance&messageReplyOption=REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD" "$RESOURCE" "OIDC Conformance Test"
elif [ $SEND_CHAT == "NO" ]; then
echo "========================================"
echo "Skipped Sending Google Chat Message"
Expand Down
2 changes: 1 addition & 1 deletion oidc-conformance-tests/send_chat.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
try:
# send google chat notification
response = http_obj.request(
uri=google_chat_webhook + "&threadKey=oidc-conformance-test",
uri=google_chat_webhook,
method='POST',
headers=message_headers,
body=json.dumps(message),
Expand Down

0 comments on commit 1ef6908

Please sign in to comment.