-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding integration tests for response modes including JARM response modes #16726
Conversation
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6252449488
*/ | ||
private AuthorizationCode getAuthorizationCode(String url, String responseMode) | ||
throws URISyntaxException { | ||
String code; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String code; | |
String code; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed with 52a5410
Assert.assertTrue(url.contains("response"), | ||
"Response JWT not found in the response."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assert.assertTrue(url.contains("response"), | |
"Response JWT not found in the response."); | |
Assert.assertTrue(url.contains("response"), Response JWT not found in the response."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed with 52a5410
import java.io.IOException; | ||
import java.net.URISyntaxException; | ||
import java.text.ParseException; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not use star imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed with 52a5410
This PR contains the integration tests to test response modes in /authorize call. Tests include both plain response mode tests as well as JARM response mode tests
Issue: #16724