Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the integration test #18589

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Modify the integration test #18589

merged 5 commits into from
Dec 19, 2023

Conversation

sahandilshan
Copy link
Contributor

Purpose

Modify the integration tests to work with the changes that we are going to do with [1]. With [2], we gonna enable the oauth. drop_unregistered_scopes and set oauth. allowed_scopes by default. So to work with the newest config, we need to modify these test cases.

[1] - #17551
[2] - wso2/carbon-identity-framework#5284

*** Note: We need to revert the 563c8c0 once [2] got merged.

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7209097563

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7209097563
Status: failure

@sahandilshan
Modify the tests to work with drop_unregistered_scopes config
f3731a8 
With wso2#17551, we will enable the drop_unregistered_scopes by default [1]. If we did that, the above tests will get failed and we need to modify them accordingly to work with the newest changes

[1] - wso2/carbon-identity-framework#5284
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7246176705

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7246176705
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7246176705

@sahandilshan
Copy link
Contributor Author

Removed the deployment.toml changes and force pushed only the modified tests since the PR builder got success

@sahandilshan sahandilshan mentioned this pull request Dec 19, 2023
Merged
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7258438932

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7258438932
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7258843127

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7258843127
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7258843127

@sahandilshan sahandilshan merged commit c9f1913 into wso2:master Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SujanSanjula96 SujanSanjula96 SujanSanjula96 approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahandilshan @jenkins-is-staging @SujanSanjula96