Add integration tests for managing user defined federated authenticator #21646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
4 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Thisara-Welmilla
force-pushed
the
add-cutsom-fed-mgt-test
branch
from
10c3263 to
2038e0b
Compare
Thisara-Welmilla
force-pushed
the
add-cutsom-fed-mgt-test
branch
2 times, most recently
from
9d0bd2c to
13333d5
Compare
Thisara-Welmilla
force-pushed
the
add-cutsom-fed-mgt-test
branch
from
13333d5 to
e8126f4
Compare
malithie
reviewed
Nov 19, 2024
| String location = response.getHeader(HttpHeaders.LOCATION); | ||
| assertNotNull(location); | ||
| customIdPId = location.substring(location.lastIndexOf("/") + 1); | ||
| assertNotNull(customIdPId); |
There was a problem hiding this comment.
Ideally IdP details should be verified. Can we verify this for user defined authenticator at least
malithie
reviewed
Nov 19, 2024
Comment on lines
+304
to
+310
| public Endpoint getEndpoint() { | ||
| return endpoint; | ||
| } | ||
| public void setEndpoint(Endpoint endpoint) { | ||
| this.endpoint = endpoint; | ||
| } | ||
|
|
There was a problem hiding this comment.
These file are auto generated files from the API server repo (from gen component).
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Add integration tests for managing user defined federated authenticators.
Related PRs: