Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix association of VFC files with related CRAM files #322

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix association of VFC files with related CRAM files #322

merged 1 commit into from
Jun 7, 2024

Conversation

kjsanger
Copy link
Member

@kjsanger kjsanger commented Jun 7, 2024

There were two complementary bugs here, which allowed associations for QC files to work, but failed for files in the same collection as the cram file, e.g. VCF files.

@kjsanger
Fix association of VFC files with related CRAM files
57cfbd6 
There were two complementary bugs here, which allowed associations for
QC files to work, but failed for files in the same collection as the
cram file, e.g. VCF files.
@kjsanger kjsanger added the bug Something isn't working label Jun 7, 2024
mgcam
mgcam approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@mgcam mgcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An interesting bug (or bugs) to catch. Shows the value of testing with different file types/directory structures

@mgcam mgcam merged commit 2f277ed into wtsi-npg:devel Jun 7, 2024
5 checks passed
@kjsanger kjsanger deleted the bug/classify-qc-file branch October 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgcam mgcam mgcam approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjsanger @mgcam