Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to TreePublisher to write json file and expose it in npg_tree_publisher script #368

Conversation

marcomoscasgr
Copy link
Contributor

This branch aims to add a method in the TreePublisher class. The function writes the irods top collection folder to json file only if the attribute mlwh_json is set. Issue #363.

Copy link
Member

@kjsanger kjsanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues remaining to look at

lib/WTSI/NPG/HTS/TreePublisher.pm Outdated Show resolved Hide resolved
lib/WTSI/NPG/HTS/TreePublisher.pm Outdated Show resolved Hide resolved
lib/WTSI/NPG/HTS/TreePublisher.pm Show resolved Hide resolved
lib/WTSI/NPG/HTS/TreePublisher.pm Outdated Show resolved Hide resolved
lib/WTSI/NPG/HTS/TreePublisher.pm Outdated Show resolved Hide resolved
lib/WTSI/NPG/HTS/TreePublisher.pm Outdated Show resolved Hide resolved
@marcomoscasgr marcomoscasgr requested a review from kjsanger April 21, 2022 09:02
@kjsanger kjsanger merged commit fcc4e17 into wtsi-npg:devel Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants