Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ORM for ml warehouse. #245

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Updated ORM for ml warehouse. #245

merged 2 commits into from
Dec 20, 2024

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Dec 20, 2024

Brought all classes in line with the production database schema. Introduced declarative style column definitions.

mgcam added 2 commits December 20, 2024 16:10
@mgcam
Updated ORM for ml warehouse.
0204e04 
Brought all classes in line with the production database
schema. Introduced declarative style column definitions.
@mgcam
A class for aliquot table is added to mlwh ORM.
23d4556
@mgcam mgcam requested a review from nerdstrike December 20, 2024 16:26
nerdstrike
nerdstrike approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqlacodegen continues to fall just short of what we'd like, but it's sufficient for our unit tests.

@nerdstrike nerdstrike merged commit 2430bc9 into wtsi-npg:devel Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdstrike nerdstrike nerdstrike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgcam @nerdstrike