Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the top-level source code directory. #57

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Apr 18, 2024

Renamed the top-level source code directory from server to src to be compliant with the team's practice and to allow for a namespace for CLI tools in the same source tree.

mgcam added 3 commits April 18, 2024 10:51
Renamed the top-level source code directory from `server`
to `src` to be compliant with the team's practice and to
allow for a namespace for CLI tools in the same source tree.
npg.porch is collapsed into npg_porch
npg.porchdb is reorganised into npg_porch.db
The entry point of the application is relocated and
renamed npg/porch_server.py -> npg_porch/server.py

Import statements in teh code and tests and docs are
updated.
@mgcam mgcam force-pushed the update_top_level_name branch from a3786c5 to 22455e5 Compare April 18, 2024 13:52
Copy link
Contributor

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of setup.cfg, because the src folder should be searched by default.

@mgcam
Copy link
Member Author

mgcam commented Apr 18, 2024

I think we can get rid of setup.cfg, because the src folder should be searched by default.

Done. The tests still pass.

@mgcam mgcam force-pushed the update_top_level_name branch from 89d5a9d to 7dfcdf7 Compare April 18, 2024 21:13
Copy link
Contributor

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@nerdstrike nerdstrike merged commit 90a3fc5 into wtsi-npg:devel Apr 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants