Add an endpoint for creating pipeline tokens #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a POST endpoint to be used with the admin token to create tokens for a pipeline. There is no limit on the number of tokens that can be created for a particular pipeline.
|
Looks good to me |
nerdstrike
approved these changes
Jun 14, 2024
| except NoResultFound: | ||
| raise HTTPException(status_code=404, | ||
| detail=f"Pipeline '{pipeline_name}' not found") | ||
| return Response(status_code=status.HTTP_201_CREATED, content=token, media_type="text/plain") |
There was a problem hiding this comment.
I don't care that much, but it's a bit naughty to return different content-types depending on whether the request was executed correctly. Content negotiation would be ideal, but fastapi isn't very good at this side of API compliance.
|
Err.. okay - I was working on a fix. I'll open a new PR to address it. Your comment also made me consider whether having JSON Content-Type for everything apart from one call was a good idea. |
|
Oops. Sorry! |
|
Although now if I return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a POST endpoint to be used with the admin token to create tokens for a pipeline. There is no limit on the number of tokens that can be created for a particular pipeline.