Add a Token model and return this instead of a bare string #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the token creation endpoint better aligned with the others in behaviour (all now return JSON with correct Content-Type for both success and HTTP errors). The token JSON includes the relevant pipeline name and token description, an improvment over anonymous strings.
nerdstrike
reviewed
Jun 17, 2024
There was a problem hiding this comment.
The changes are fine. Do you think the user guide needs a minor modification now that it's a structured response?
I'm still quietly cursing fastapi for not implementing content negotation. It seems you have to throw out half of the advantage of fastapi to do it properly.
Yes - let me check that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the token creation endpoint better aligned with the others in behaviour (all now return JSON with correct Content-Type for both success and HTTP errors).
The token JSON includes the relevant pipeline name and token description, an improvment over anonymous strings.