Stopped errors for requests to create an existing tasks. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status 200 is returned instead of previously returned 409.
nerdstrike
requested changes
Jun 27, 2024
docs/user_guide.md
Outdated
| Once a task has been submitted, and a 201 CREATED response has been received, the npg_porch server assigns a timestamp to the task, gives it a status of `PENDING` and assigns a unique ID to it. The response from the server contains this extra information. | ||
|
|
||
| A 200 OK response means that this particular task for this pipeline has already been registered. The current representation of the task is returned, the status of teh task might be differ from `PENDING`. Note that if there are many tasks to register, some of which were submitted previously, further work is required to make the process efficient - such as to ask the npg_porch server for a list of previously registered tasks for this pipeline. |
src/npg_porch/db/data_access.py
Outdated
| change='Created' | ||
| ) | ||
| t.events.append(event) | ||
| nested = await session.begin_nested() |
There was a problem hiding this comment.
huh, I expected the subsession to be in the exception handling, but it if it works it's fine.
| from npg_porch.auth.token import validate | ||
| from npg_porch.db.connection import get_DbAccessor | ||
| from npg_porch.models.permission import RolesEnum |
There was a problem hiding this comment.
I guess we're gradually homogenising the code module by module. It's a good thing
mgcam
force-pushed
the
ok_to_register_repeatedly
branch
from
28639f5 to
04f1a0c
Compare
nerdstrike
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status 200 is returned instead of previously returned 409.