Update Task model validation to prevent status being NULL #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the eq method of Task so that it doesn't raise ValidationError when the "other" object is a dict which isn't a valid task. It should simply return that they are not equal. Simplified the eq method a bit by removing redundant "else"s. Some expected test results needed changing to accommodate the new Task status.
Avoid setting a default value for status to ensure that it must be set explicitly. The create_task method in the database layer now has exclusive control over whether a default (of PENDING) is set, which it does only when a new task record is created, not when an exisiting task record is updated.
|
I should add that the reason I'm suggesting a change is that by sending a POST with a status accidentally missing, I managed to set all the tasks to a NULL status in the database and then consequently couldn't find them. |
nerdstrike
approved these changes
Jul 12, 2024
mgcam
approved these changes
Jul 12, 2024
mgcam
added a commit
to mgcam/npg_porch_cli
that referenced
this pull request
Jul 17, 2024
Following wtsi-npg/npg_porch#72, Status code 422 "Unprocessable Entity" error is received from the server if the status is not set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Task model validation to prevent status being NULL
Change the eq method of Task so that it doesn't raise ValidationError when the "other" object is a dict which isn't a valid task. It should simply return that they are not equal.
Simplified the eq method a bit by removing redundant "else"s.
Some expected test results needed changing to accommodate the new Task status.