Release 2.0 #74
Merged
Release 2.0 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a file for logging changes
Renamed the top-level source code directory from `server` to `src` to be compliant with the team's practice and to allow for a namespace for CLI tools in the same source tree.
npg.porch is collapsed into npg_porch npg.porchdb is reorganised into npg_porch.db The entry point of the application is relocated and renamed npg/porch_server.py -> npg_porch/server.py Import statements in teh code and tests and docs are updated.
Renamed the top-level source code directory.
Add a note about installing on macOS
Add a POST endpoint to be used with the admin token to create tokens for a pipeline. There is no limit on the number of tokens that can be created for a particular pipeline.
Add model validation to the Pydantic class to forbid extra fields. This prevents the endpoint returning that a pipeline already exists (409) when it fails to create a row in the database due to constraint violation (NULL because of a misspelled field).
Fix pipelines endpoint to return HTTP 422 on bad input rather than 409
Add an endpoint for creating pipeline tokens
This makes the token creation endpoint better aligned with the others in behaviour (all now return JSON with correct Content-Type for both success and HTTP errors). The token JSON includes the relevant pipeline name and token description, an improvment over anonymous strings.
Add a Token model and return this instead of a bare string
Remove variable assignments that are never used
Add a development Dockerfile
Add Dependabot configuration for pip and GitHub Actions
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Status 200 is returned instead of previously returned 409.
…s/checkout-4 Bump actions/checkout from 3 to 4
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v2...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…s/setup-python-5 Bump actions/setup-python from 2 to 5
Stopped errors for requests to create an existing tasks.
Moved pysqlite3 to test dependencies
Change the eq method of Task so that it doesn't raise ValidationError when the "other" object is a dict which isn't a valid task. It should simply return that they are not equal. Simplified the eq method a bit by removing redundant "else"s. Some expected test results needed changing to accommodate the new Task status.
Avoid setting a default value for status to ensure that it must be set explicitly. The create_task method in the database layer now has exclusive control over whether a default (of PENDING) is set, which it does only when a new task record is created, not when an exisiting task record is updated.
Update Task model validation to prevent status being NULL
Logged changes for release 1.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.