Copy script from gitlab project #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported a client script for interaction with the npg_porch server from an internal GitLab project. To avoid hardcoding pipeline details, created two additional script arguments, pipeline_url and pipeline_version. Replaced real token values with placeholders.
mgcam
force-pushed
the
copy_script_from_gitlab_project
branch
from
a9c430c to
a437f40
Compare
Updated project dependencies.
mgcam
force-pushed
the
copy_script_from_gitlab_project
branch
from
a437f40 to
9e6b1da
Compare
nerdstrike
reviewed
Apr 25, 2024
.flake8
Outdated
| @@ -1,4 +1,6 @@ | |||
| [flake8] | |||
| max-line-length = 100 | |||
| extend-select = B950 | |||
| extend-ignore = E203, E501, E701 | |||
There was a problem hiding this comment.
These look a redundant for the script at least. You still want them?
There was a problem hiding this comment.
How do you feel about aa594ee and starting from a clean slate?
And configure flake8 in pyproject.toml
nerdstrike
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.