Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow emply applicability criteria #879

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Sep 18, 2024

No description provided.

@mgcam mgcam force-pushed the disallow_no_applicability branch from f242904 to af9c7da Compare September 19, 2024 12:54
@mgcam mgcam force-pushed the disallow_no_applicability branch from af9c7da to 73f5f8a Compare October 9, 2024 12:34
Changes Outdated
filter was the study id. In the default section of the product configuration
file there is no external filter, so there is a real danger of the review
check being run indiscriminately for any product. While this will never be
an intension, small errors in the YML file might have this effect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ? intention ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, ready to be merged

@mgcam mgcam force-pushed the disallow_no_applicability branch from 73f5f8a to 5246247 Compare October 15, 2024 07:59
@ces ces merged commit 3eab96d into wtsi-npg:devel Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants