Skip to content

Commit

Permalink
Removed deprecated methods for retrieving lims object descendants
Browse files Browse the repository at this point in the history
  • Loading branch information
mgcam committed Oct 24, 2023
1 parent fa60e2b commit 9b240ab
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 25 deletions.
4 changes: 2 additions & 2 deletions lib/npg_tracking/data/reference/find.pm
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ sub refs {
$spiked_phix_index = $self->lims->spiked_phix_tag_index;
}

my @alims = $self->lims->associated_lims;
my @alims = $self->lims->descendants;
if (!@alims) {
@alims = ($self->lims);
}
Expand Down Expand Up @@ -471,7 +471,7 @@ Marina Gourtovaia E<lt>[email protected]<gt>
=head1 LICENSE AND COPYRIGHT
Copyright (C) 2017 GRL
Copyright (C) 2013,2014,2015,2016,2017,2018,2019,2023 Genome Research Ltd.
This file is part of NPG.
Expand Down
25 changes: 2 additions & 23 deletions lib/st/api/lims.pm
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ sub _build_required_insert_size {

my $is_hash = {};
if (defined $self->position) {
my @alims = $self->associated_lims;
my @alims = $self->descendants;
@alims = @alims ? @alims : ($self);
foreach my $lims (@alims) {
if ($lims->is_control) {
Expand Down Expand Up @@ -1012,20 +1012,6 @@ sub descendants {
return @lims;
}

=head2 associated_lims
The same as descendants. Retained for backward compatibility
=cut
*associated_lims = \&descendants; #backward compat

=head2 associated_child_lims
The same as children. Retained for backward compatibility
=cut
*associated_child_lims = \&children; #backward compat

=head2 children_ia
Method providing fast (index-based) access to child lims object.
Expand Down Expand Up @@ -1071,13 +1057,6 @@ sub sample_publishable_name {
return $self->sample_accession_number() || $self->sample_public_name() || $self->sample_name();
}

=head2 associated_child_lims_ia
The same as children_ia. Retained for backward compatibility
=cut
*associated_child_lims_ia = \&children_ia; #backward compat

sub _list_of_attributes {
my ($self, $attr_name, $with_spiked_control) = @_;
my @l = ();
Expand Down Expand Up @@ -1396,7 +1375,7 @@ Marina Gourtovaia E<lt>[email protected]<gt>
=head1 LICENSE AND COPYRIGHT
Copyright (C) 2013,2014,2015,2016,2017,2018,2019,2020,2021 Genome Research Ltd.
Copyright (C) 2013,2014,2015,2016,2017,2018,2019,2020,2021,2023 Genome Research Ltd.
This file is part of NPG.
Expand Down

0 comments on commit 9b240ab

Please sign in to comment.