Merge pull request #728 from wtsi-npg/devel

pull from devel to master to create release 94.0.1

Changes

@@ -1,5 +1,10 @@
 LIST OF CHANGES
 
+release 94.0.1
+ - Fixed bugs in the staging area daemon script:
+   - an incorrect method name
+   - use of previously deleted method
+
 release 94.0.0
  - Added checks for on-board analysis in progress
  - Improved logging for a long wait case

bin/staging_area_monitor

@@ -21,6 +21,7 @@ Readonly::Scalar my $SLEEP_INTERVAL => 60 * 15;
 Readonly::Scalar my $DRY_RUN => $ENV{'dev'} && ($ENV{'dev'} ne 'live');
 Readonly::Array  my @UPDATES_FOR_INCOMING_ALLOWED_STATUSES =>
   ('run pending', 'run in progress', 'run complete');
+Readonly::Scalar my $USERNAME => 'pipeline';
 
 local $OUTPUT_AUTOFLUSH = 1;
 
@@ -50,7 +51,7 @@ sub check_path { ##### Function to deal with one run folder
     my $id_run = $folder->tracking_run()->id_run;
 
     _log("Run $id_run status $run_status");
-    if ($folder->platform_is_NovaSeqX()) {
+    if ($folder->platform_NovaSeqX()) {
         _log("... run on NovaSeqX instrument");
     }
 
@@ -87,7 +88,7 @@ sub check_path { ##### Function to deal with one run folder
     # 'run complete'. We might consider reinstating this rule.
     if ( not defined $previous_size_of->{$run_path} ) {
         $folder->update_run_record();
-        $folder->tracking_run()->set_tag( $folder->username(), 'staging' );
+        $folder->tracking_run()->set_tag( $USERNAME, 'staging' );
         _log('Set staging tag');
         try {
             my $iside = $folder->set_instrument_side();