Added a method for aggregation by library #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgcam
force-pushed
the
merge_by_library
branch
from
556f073 to
863982a
Compare
mgcam
force-pushed
the
merge_by_library
branch
from
863982a to
c9a37bd
Compare
Moved tests for aggregation across lanes to a new test scripts. Tests for a new merge by library method will be added to this new test script.
mgcam
force-pushed
the
merge_by_library
branch
4 times, most recently
from
627d467 to
baf8122
Compare
Also refactored the method itself.
mgcam
force-pushed
the
merge_by_library
branch
from
baf8122 to
0127b18
Compare
dkj
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Code eye-balled and together with tests here and use of change with downstream library/tools all suggest this is good.
The aggregation method is conservative/safe - we could potentially relax contraints in the future such as the mentioned run level (but also common tag_index, common set across lanes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.