Record all recent changes #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmtcsngr
reviewed
Oct 31, 2023
Changes
Outdated
| - Removed the use of 'xml' lims driver from all tests. | ||
| - Deleted 'xml' lims driver class and all classes, which supported this | ||
| functionality, together with all related tests and test data. | ||
| - In release 97.0.0, ihe default LIMS driver type in samplesheet generation |
There was a problem hiding this comment.
Suggested change
| - In release 97.0.0, ihe default LIMS driver type in samplesheet generation | |
| - In release 97.0.0, the default LIMS driver type in samplesheet generation |
Changes
Outdated
| @@ -1,5 +1,35 @@ | |||
| LIST OF CHANGES | |||
|
|
|||
| - Removed the use of 'xml' lims driver from all tests. | |||
| - Deleted 'xml' lims driver class and all classes, which supported this | |||
There was a problem hiding this comment.
Suggested change
| - Deleted 'xml' lims driver class and all classes, which supported this | |
| - Deleted 'xml' lims driver class and all classes which supported this |
Changes
Outdated
| - reimplemented the 'reference_genome' method to exclude a fallback to | ||
| a study reference for tag zero and lane-level objects when samples | ||
| have different references. | ||
| - Restricted the 'all_lanes_mergeable' flag in the 'lonf_info' role to |
There was a problem hiding this comment.
Suggested change
| - Restricted the 'all_lanes_mergeable' flag in the 'lonf_info' role to | |
| - Restricted the 'all_lanes_mergeable' flag in the 'long_info' role to |
Changes
Outdated
| removal: | ||
| - deleted all previously deprecated methods ('seq_qc_state', | ||
| 'associated_lims', 'associated_child_lims', 'associated_child_lims_ia'); | ||
| - deleted methods, for which we do not have data in ml warehouse, our |
There was a problem hiding this comment.
Suggested change
| - deleted methods, for which we do not have data in ml warehouse, our | |
| - deleted methods for which we do not have data in ml warehouse, our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.