Daemon4novaseqx samplesheet #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgcam
force-pushed
the
daemon4novaseqx_samplesheet
branch
from
75d1bd5 to
474a510
Compare
Added a test to test the correctness of passing the option to teh samplesheet generator.
mgcam
force-pushed
the
daemon4novaseqx_samplesheet
branch
from
3f960da to
58ce63d
Compare
jmtcsngr
reviewed
Jan 4, 2024
The old samplesheet generator had this ability. Rearranged the code so that the samplesheet generator for NovaSeqX also has this ability, which simplifies the code in the samplesheet daemon. NovaSeqX samplesheet generator retains ability to generate a samplesheet when neither id_run nor the run db record is set via the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #795