Removed st::api::lims batch_id constructor arg. #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was needed when we used the xml driver. No current lims driver is using this argument. Existing production code does not pass batch_id to st::api::lims constructor. st::api::lims documentation updated.
jmtcsngr
reviewed
Jan 4, 2024
lib/st/api/lims.pm
Outdated
| to the database defined in a standard NPG configuration file is be used. | ||
|
|
||
| Any driver attribute can be passed through to the driver's constructor via | ||
| this objects's constructor. Not all of the attributes passed through to the |
There was a problem hiding this comment.
Suggested change
| this objects's constructor. Not all of the attributes passed through to the | |
| this object's constructor. Not all of the attributes passed through to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was needed when we used the xml driver.
No current lims driver is using this argument. Existing production code does not pass batch_id to st::api::lims constructor.
st::api::lims documentation updated.