Update emails for status change #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgcam
requested changes
Jan 18, 2024
Changes
Outdated
| @@ -14,6 +14,9 @@ LIST OF CHANGES | |||
| - Extended the code for the samplesheet daemon to generate samplesheets for | |||
| NovaSeqX instruments. | |||
| - Removed remaining unused test data from the era of xml st::api::lims driver. | |||
| - update signature and iRODS documentation link in template for emails | |||
There was a problem hiding this comment.
Would be good to keep the same style for Changes. So update -> Updated, remove -> Removed
Changes
Outdated
| @@ -14,6 +14,9 @@ LIST OF CHANGES | |||
| - Extended the code for the samplesheet daemon to generate samplesheets for | |||
| NovaSeqX instruments. | |||
| - Removed remaining unused test data from the era of xml st::api::lims driver. | |||
| - update signature and iRODS documentation link in template for emails | |||
| - remove link to illumina/runs qc page in emails reporting status when run | |||
| reaches qc complete | |||
There was a problem hiding this comment.
The emails are triggered by a number of statuses, not only by 'qc complete'. That's why the text say 'this run will be/is available'
| @@ -1,2 +1,2 @@ | |||
| [% content %] | |||
| NPG, DNA Pipelines Informatics | |||
| NPG on behalf of DNA Pipelines | |||
|
Could tracking url can be changed to https://sfweb.internal.sanger.ac.uk:12443/perl/npg? See https://github.com/wtsi-npg/npg_tracking/blob/devel/data/npg_tracking_email/templates/urls.tt2 |
jmtcsngr
force-pushed
the
up_mail
branch
2 times, most recently
from
465da0c to
81939d9
Compare
mgcam
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signature change as well as updating the iRODS help page link.
Remove (temp) the link to runs/illumina qc page.