Update staging monitor tests #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used current staging directories structure. Used run Illumina's native run folder names. Stopped using HiSeq-specific run folder files.
jmtcsngr
reviewed
Feb 8, 2024
t/34-monitor-runfolder-staging.t
Outdated
| $test = Monitor::RunFolder::Staging->new( runfolder_path => '/export/sf25/ILorHSany_sf25/incoming/110712_HS8_06541_B_B0A6DABXX'); | ||
| is($test->_get_folder_path_glob, '/{export,nfs}/sf25/ILorHSany_sf25/*/', 'glob for /export/sf25 incoming'); | ||
| } | ||
| subtest 'seting file system permissions' => sub { |
There was a problem hiding this comment.
Suggested change
| subtest 'seting file system permissions' => sub { | |
| subtest 'setting file system permissions' => sub { |
t/34-monitor-runfolder-staging.t
Outdated
| for my $dir (qw/incoming analysis outgoing/) { | ||
| my $rfpath = $path; | ||
| $rfpath =~ s/outgoing/$dir/; | ||
| note $rfpath; |
There was a problem hiding this comment.
Suggested change
| note $rfpath; | |
| note 'Testing ' . $rfpath; |
t/34-monitor-runfolder-staging.t
Outdated
|
|
||
| for my $file_name (qw[CopyComplete Copycomplete | ||
| copycomplete CopyComplete_old.txt ]) { | ||
| note $file_name; |
There was a problem hiding this comment.
Suggested change
| note $file_name; | |
| note 'Testing ' . $file_name; |
| @@ -99,42 +96,39 @@ subtest 'updating run data from filesystem' => sub { | |||
| expected_cycle_count => 310, | |||
| actual_cycle_count => 0, | |||
There was a problem hiding this comment.
Just to make sure we have setup thing for following tests and rely less on the yml fixture loading
Suggested change
| actual_cycle_count => 0, | |
| actual_cycle_count => 0, | |
| folder_name => undef, | |
| folder_path_glob => undef, |
t/34-monitor-runfolder.t
Outdated
| open my $fh2, '>', join(q[/], $rf, 'runParameters.xml'); | ||
| print $fh2 $run_parameters; | ||
| close $fh2; | ||
|
|
||
| # Creade 8 lane records in the database |
There was a problem hiding this comment.
Suggested change
| # Creade 8 lane records in the database | |
| # Create 8 lane records in the database |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove old test data