Merge pull request #310 from ces/empty_dag

Change to  populate_wtsi_irods_groups.pl for empty data access groups

Changes

@@ -1,3 +1,9 @@
+Unreleased
+
+ - Change populate_wtsi_irods_groups.pl to only populate iRODS
+   study access groups with all seq iRODS users for SS studies
+   with empty data access where the study is not managed e.g.
+   submitted to EGA not ENA
 
 Release 3.23.0 (2024-07-25)
 

bin/populate_wtsi_irods_groups.pl

@@ -17,6 +17,8 @@
 
 our $VERSION = '';
 
+Readonly::Scalar my $MANAGED_TYPE => q{managed};
+
 my $what_on_earth =<<'WOE';
 
 Script to update WTSI iRODS systems with groups corresponding to
@@ -38,11 +40,11 @@
 and iRODS public group is used as the membership of the corresponding
 iRODS group.
 
-If no data_access_group is set on the study, then if the study is
-associated with sequencing the members of the iRODS group will be set
-to the public group, else if the study is not associated with
-sequencing tracked in the ML warehouse, the iRODS group will be left
-empty (except for the iRODS groupadmin user).
+If no data_access_group is set on the Sequencescape study, then if the 
+study doesn't have a data release type of managed the members of the 
+iRODS group will be set to the public group, else if the study has a 
+data release type of managed the iRODS group will be left empty (except
+for the iRODS groupadmin user).
 
 Studies which are marked as have samples contaminated with human which
 should be removed will have an ss_<study_id>_human iRODS group created
@@ -163,7 +165,7 @@ sub _uid_to_irods_uid {
     @members = map { _uid_to_irods_uid($_) }
                map { @{ $group2uids->{$_} || [$_] } } @dags;
   }
-  elsif ($is_seq) {
+  elsif ($study->data_release_strategy ne $MANAGED_TYPE) {
     @members = @public;
   }
   else {