Enable RMQ messaging for Publisher in production #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainrb
commented
Dec 11, 2017
iainrb
commented
- Add PublisherFactory and PublisherWithMessaging classes, with tests
- The PublisherFactory returns a PublisherWithMessaging if RabbitMQ is enabled; Publisher otherwise
- RabbitMQ classes are imported at runtime using 'require'; allows running without RabbitMQ prerequisites installed
- PublisherWithMessaging replaces PublisherMQTest
- Shared RMQ test methods moved into TestRabbitMQ.pm
- TODO Add parameters to explicitly enable/disable RabbitMQ instead of relying on the NPG_RMQ_CONFIG environment variable
|
Additions in commit 50ba359
|
keithj
reviewed
Dec 18, 2017
|
|
||
| has 'exchange' => | ||
| (is => 'ro', | ||
| isa => 'Maybe[Str]', |
There was a problem hiding this comment.
Please use predicates instread of MayBe see wtsi-npg/npg_irods#89
| my $exchange_key = 'exchange'; | ||
| my $prefix_key = 'routing_key_prefix'; | ||
| my @rmq_keys = ($exchange_key, $prefix_key); | ||
| foreach my $key (@rmq_keys) { |
There was a problem hiding this comment.
There should be no need to check initargs this because Publisher uses MooseX::StrictConstructor. If you're accepting arguments to the factory method that need validating, it may be better to configure the factory to do the work and just allow some minimal positional parameters for the factory method itself.
| use Moose; | ||
| use strict; | ||
| use warnings; | ||
| use Moose::Role; |
There was a problem hiding this comment.
Why changed to a role? These methods will now appear in the public API of anything that consumes them - do they need to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.