custom component for path input #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new component and corresponding API changes to support a custom path input for arguments across the frontend and backend. Key changes include:
- Extending the argument types with PATH and adding associated type guards and model types.
- Creating a new React component (PathInput) for selecting paths using a tree view.
- Updating the backend with a new PathArgument class and integrating it into the argument configuration.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui.frontend/src/utils/api.types.ts | Added PATH into ArgumentType and defined related type and type guard functions. |
| ui.frontend/src/components/PathInput.tsx | Introduced a new PathInput component based on a tree view for path selection. |
| ui.frontend/src/components/CodeArgumentInput.tsx | Updated to conditionally render the new PathInput component for PATH arguments. |
| ui.content/src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/path.yml | Added snippet definition for path arguments. |
| core/src/main/java/com/vml/es/aem/acm/core/code/arg/PathArgument.java | Created a new class for PATH type arguments. |
| core/src/main/java/com/vml/es/aem/acm/core/code/Arguments.java | Integrated new methods to construct PATH arguments. |
| core/src/main/java/com/vml/es/aem/acm/core/code/ArgumentType.java | Extended enum to include PATH. |
Files not reviewed (1)
- ui.frontend/src/components/PathInput.module.css: Language not supported
| @@ -87,7 +86,7 @@ const ExecutionView = () => { | |||
| <View backgroundColor="gray-50" padding="size-200" borderRadius="medium" borderColor="dark" borderWidth="thin"> | |||
| <Flex direction="row" justifyContent="space-between" gap="size-200"> | |||
| <LabeledValue label="ID" value={execution.id} flex="1" /> | |||
| <LabeledValue label="User" value={execution.userId} flex="1" /> | |||
| <LabeledValue label="User" value={execution.userId ? execution.userId : "unknown"} flex="1" /> | |||
There was a problem hiding this comment.
It was throwing errors during development, so I added default version. Do we want to keep it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.