Fix #558: SMS does not respect accept-language #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrdvorak
approved these changes
Dec 8, 2022
...c/main/java/com/wultra/app/onboardingserver/impl/service/IdentityVerificationOtpService.java
Show resolved
Hide resolved
|
What happens when the user switches language during onboarding process in app settings, will the next SMS arrive in correct language? |
Good point! We have discussed it with @kober32 and accepted that scenario. Do you expect that it will happen often? If so, we may update custom_data more often, but is it too big overhead? |
|
I suggest to raise a separate ticket. The overhead is minimal, we can just check whether the language has changed and update the locale. |
|
Opened #563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update script for existing environments