Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unsafeChangePassword() methods #664

Conversation

hvge
Copy link
Member

@hvge hvge commented Jan 17, 2025

This PR deprecates synchronous methods that change the password locally on the device. This is due to fact that this kind of interfaces will no longer be available in Crypto4 protocol version.

@hvge hvge requested a review from kober32 January 17, 2025 12:29
@hvge hvge changed the title Deprecate unsafeChangePassword() methods. Deprecate unsafeChangePassword() methods Jan 17, 2025
@hvge hvge requested a review from petrdvorak January 20, 2025 09:39
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

Base automatically changed from feature/628-activation-data-sharing-docs to feature/650-remove-recovery-codes January 20, 2025 12:04
@hvge hvge merged commit 9c1e000 into feature/650-remove-recovery-codes Jan 20, 2025
1 check passed
@hvge hvge deleted the feature/530-deprecate-unsafechangepassword branch January 20, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants