Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure consistent hash for operations #1367

Merged
merged 24 commits into from
Dec 11, 2024
Merged

feat: ensure consistent hash for operations #1367

merged 24 commits into from
Dec 11, 2024

Conversation

StarpTech
Copy link
Contributor

@StarpTech StarpTech commented Nov 13, 2024 •
edited by JivusAyrus
Loading

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

FIXES ENG-6013

@JivusAyrus JivusAyrus marked this pull request as ready for review November 28, 2024 08:24
@StarpTech StarpTech changed the title chore: add failing test for content normalization hashes feat: make operation hash more reliable in variable usage scenarios Nov 28, 2024
@StarpTech StarpTech changed the title feat: make operation hash more reliable in variable usage scenarios feat: make operation hashing more reliable in variable usage scenarios Nov 28, 2024
StarpTech and others added 6 commits November 28, 2024 19:32
@StarpTech
chore: build hash on normalized operation
fdafe71
@JivusAyrus
fix: persisted operations
58146c8
@JivusAyrus
fix: tests
506f307
@JivusAyrus
fix: tests
9261520
@JivusAyrus
Merge branches 'dustin/eng-5934-queries-with-inline-variable-values-a…
a03fce7 
…rent-normalized' and 'main' of github.com:wundergraph/cosmo into dustin/eng-5934-queries-with-inline-variable-values-arent-normalized
@JivusAyrus
fix: test
0465e25
@StarpTech StarpTech changed the title feat: make operation hashing more reliable in variable usage scenarios feat: ensure consistent hash for operations Nov 29, 2024
Noroth
Noroth reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Noroth Noroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

router-tests/normalization_test.go Outdated Show resolved Hide resolved
router-tests/normalization_test.go Outdated Show resolved Hide resolved
@JivusAyrus JivusAyrus merged commit 9e516e4 into main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JivusAyrus JivusAyrus JivusAyrus left review comments

@Noroth Noroth Noroth approved these changes

@jensneuse jensneuse jensneuse approved these changes

@devsergiy devsergiy Awaiting requested review from devsergiy

Assignees
No one assigned
Labels
router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StarpTech @Noroth @jensneuse @JivusAyrus