Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expressions): avoid exposing more methods as desired #1486

Merged
merged 7 commits into from
Jan 5, 2025
Merged

fix(expressions): avoid exposing more methods as desired #1486

merged 7 commits into from
Jan 5, 2025

Conversation

StarpTech
Copy link
Contributor

@StarpTech StarpTech commented Jan 4, 2025 •
edited
Loading

Motivation and Context

expr-lang/expr#744

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@StarpTech StarpTech requested review from Noroth and jensneuse January 4, 2025 14:01
@github-actions github-actions bot added the router label Jan 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025 •
edited
Loading

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-f4153023192a9614ddd7d92ba676dfc797127d9b

@StarpTech StarpTech changed the title fix(expressions): avoid exposing more methods than as desired fix(expressions): avoid exposing more methods as desired Jan 4, 2025
Noroth
Noroth reviewed Jan 4, 2025
View reviewed changes
Noroth
Noroth approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@Noroth Noroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech merged commit 105e7ab into main Jan 5, 2025
13 checks passed
@StarpTech StarpTech deleted the dustin/avoid-exposing-other-methods branch January 5, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noroth Noroth Noroth approved these changes

@jensneuse jensneuse Awaiting requested review from jensneuse

Assignees
No one assigned
Labels
router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarpTech @Noroth