Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscription): never try to send on blocked channel when subscription was completed #1641

Merged
merged 9 commits into from
Mar 3, 2025

Conversation

StarpTech
Copy link
Contributor

@StarpTech StarpTech commented Feb 27, 2025

Motivation and Context

Engine: wundergraph/graphql-go-tools#1100

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@StarpTech StarpTech changed the title fix(subscription): dont send on blocked channel fix(subscription): never try to send on blocked channel when subscription was completed Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-652d24f3f607ae7cc4cd408fab2e21ab0f313dcc

@StarpTech StarpTech marked this pull request as ready for review March 3, 2025 15:04
@StarpTech StarpTech requested a review from endigma March 3, 2025 16:29
@endigma
Copy link
Contributor

endigma commented Mar 3, 2025

Failing integration_test FYI, because its not required yet, looks like a race somewhere in kafka test hot path

Copy link
Contributor

@endigma endigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a flaky data race in integration_test, requesting changes in-lieu of this workflow being required

@StarpTech StarpTech merged commit 87cff19 into main Mar 3, 2025
13 checks passed
@StarpTech StarpTech deleted the dustin/avoid-blocking-send-subs branch March 3, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants