-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): schema usage lite export via prometheus #1704
Open
endigma
wants to merge
27
commits into
main
Choose a base branch
from
jesse/eng-6451-schema-usage-export-via-prometheus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Router image scan passed✅ No security vulnerabilities found in image:
|
d9f1302
to
bc8b8c9
Compare
dc2f1ea
to
f51057f
Compare
064b604
to
a4f56e0
Compare
StarpTech
requested changes
Mar 26, 2025
telemetry/metrics/prometheus
- unused by customers - filtered from prom by default when name is semantically correct
fa4f638
to
370d6cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some customers would like to use Prometheus for schema usage metrics, instead of the stack provided by Cosmo.
Changes
/telemetry/metrics/prometheus/schema_usage
include_operation_sha
controls whether or not the metrics include an attribute containing the sha256 of the operation, this can be disabled to reduce cardinalitytrue
the sha256 will unconditionally be computeddebug.config.yaml
now setslog_level: debug
telemetry.prometheus.schema_usage.enabled: true
telemetry.prometheus.schema_usage.include_operation_sha: true
Config example